Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 1452053005: SSL - minor cleanup. Added UpdateSignedCertificateTimestamps to SSLInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | net/ssl/ssl_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 00ccb3f90585b94068516f96b63448acb02bc683..0fc5d9eb048305fe5c74286aec780f4f66eadec9 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -2077,25 +2077,7 @@ int SSLClientSocketOpenSSL::NewSessionCallback(SSL_SESSION* session) {
}
void SSLClientSocketOpenSSL::AddSCTInfoToSSLInfo(SSLInfo* ssl_info) const {
- for (ct::SCTList::const_iterator iter =
- ct_verify_result_.verified_scts.begin();
- iter != ct_verify_result_.verified_scts.end(); ++iter) {
- ssl_info->signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(*iter, ct::SCT_STATUS_OK));
- }
- for (ct::SCTList::const_iterator iter =
- ct_verify_result_.invalid_scts.begin();
- iter != ct_verify_result_.invalid_scts.end(); ++iter) {
- ssl_info->signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(*iter, ct::SCT_STATUS_INVALID));
- }
- for (ct::SCTList::const_iterator iter =
- ct_verify_result_.unknown_logs_scts.begin();
- iter != ct_verify_result_.unknown_logs_scts.end(); ++iter) {
- ssl_info->signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(*iter,
- ct::SCT_STATUS_LOG_UNKNOWN));
- }
+ ssl_info->UpdateSignedCertificateTimestamps(ct_verify_result_);
}
std::string SSLClientSocketOpenSSL::GetSessionCacheKey() const {
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | net/ssl/ssl_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698