Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1452053003: Use a List for outstanding load requests (Closed)

Created:
5 years, 1 month ago by zra
Modified:
5 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use a List for outstanding load requests Saves another ms during Isolate startup. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/157cbe9738a5910fbb7986b3b18f174288900b9a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M runtime/lib/lib_prefix.dart View 1 3 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
5 years, 1 month ago (2015-11-17 21:08:09 UTC) #2
hausner
LGTM w/comment. https://codereview.chromium.org/1452053003/diff/1/runtime/lib/lib_prefix.dart File runtime/lib/lib_prefix.dart (right): https://codereview.chromium.org/1452053003/diff/1/runtime/lib/lib_prefix.dart#newcode45 runtime/lib/lib_prefix.dart:45: var _outstandingLoadRequests = new List<List>(); You lose ...
5 years, 1 month ago (2015-11-17 21:24:39 UTC) #3
zra
https://codereview.chromium.org/1452053003/diff/1/runtime/lib/lib_prefix.dart File runtime/lib/lib_prefix.dart (right): https://codereview.chromium.org/1452053003/diff/1/runtime/lib/lib_prefix.dart#newcode45 runtime/lib/lib_prefix.dart:45: var _outstandingLoadRequests = new List<List>(); On 2015/11/17 21:24:39, hausner ...
5 years, 1 month ago (2015-11-17 21:55:47 UTC) #4
zra
5 years, 1 month ago (2015-11-17 21:57:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
157cbe9738a5910fbb7986b3b18f174288900b9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698