Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 145203003: Remove extraneous folders from includes. (Closed)

Created:
6 years, 11 months ago by scroggo
Modified:
6 years, 11 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove extraneous folders from includes. Committed: http://code.google.com/p/skia/source/detail?r=13148

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove references to include/lazy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M gyp/core.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M gyp/images.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/utils.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scroggo
Are these necessary? They don't correspond to anything in our check out. I was manually ...
6 years, 11 months ago (2014-01-22 22:45:32 UTC) #1
mtklein
https://codereview.chromium.org/145203003/diff/1/gyp/core.gyp File gyp/core.gyp (left): https://codereview.chromium.org/145203003/diff/1/gyp/core.gyp#oldcode103 gyp/core.gyp:103: '../include/lazy', include/lazy also doesn't exist. :)
6 years, 11 months ago (2014-01-23 00:05:45 UTC) #2
scroggo
https://codereview.chromium.org/145203003/diff/1/gyp/core.gyp File gyp/core.gyp (left): https://codereview.chromium.org/145203003/diff/1/gyp/core.gyp#oldcode103 gyp/core.gyp:103: '../include/lazy', On 2014/01/23 00:05:45, mtklein wrote: > include/lazy also ...
6 years, 11 months ago (2014-01-23 14:09:19 UTC) #3
mtklein
lgtm
6 years, 11 months ago (2014-01-23 14:10:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/145203003/50001
6 years, 11 months ago (2014-01-23 14:13:18 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 14:30:24 UTC) #6
Message was sent while issue was closed.
Change committed as 13148

Powered by Google App Engine
This is Rietveld 408576698