Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1452013006: arc-bridge: Fix a DCHECK (Closed)

Created:
5 years, 1 month ago by Luis Héctor Chávez
Modified:
5 years, 1 month ago
Reviewers:
hidehiko, elijahtaylor1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc-bridge: Fix a DCHECK The condition of one of the DCHECKs to check that the code is running on the correct thread was wrong. BUG=554214 Committed: https://crrev.com/ac8f1aace247069df3a72eba7cbc465cbc9f8a75 Cr-Commit-Position: refs/heads/master@{#360468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/arc/arc_bridge_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Luis Héctor Chávez
PTAL
5 years, 1 month ago (2015-11-18 17:20:51 UTC) #2
hidehiko
lgtm
5 years, 1 month ago (2015-11-19 00:03:24 UTC) #3
elijahtaylor1
lgtm
5 years, 1 month ago (2015-11-19 00:04:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452013006/1
5 years, 1 month ago (2015-11-19 00:08:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:46:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:47:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ac8f1aace247069df3a72eba7cbc465cbc9f8a75
Cr-Commit-Position: refs/heads/master@{#360468}

Powered by Google App Engine
This is Rietveld 408576698