Issue 1452013004: Fix ASan gn build (chromium).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1452013004: Fix ASan gn build (chromium). (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang, Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix ASan gn build (chromium). R=thestig@chromium.org, thakis@chromium.org BUG=556808 Committed: https://pdfium.googlesource.com/pdfium/+/97f900e93e6a96b164b33bfe1228f383d9a5ecd3

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	samples/BUILD.gn	View		3 chunks	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/1452013004/diff/1/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/1452013004/diff/1/samples/BUILD.gn#newcode5 samples/BUILD.gn:5: import("//build/config/sanitizers/sanitizers.gni") I suppose some day we'll have a ...

5 years, 1 month ago (2015-11-18 01:04:29 UTC) #4

Oliver Chang

5 years, 1 month ago (2015-11-18 17:23:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
97f900e93e6a96b164b33bfe1228f383d9a5ecd3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages