Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: net/ftp/ftp_directory_listing_parser_unittest.cc

Issue 1451993007: Fix FTP dir listing parser to support servers returning a "total n" line with an incorrect negative… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_ls.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ftp/ftp_directory_listing_parser.h" 5 #include "net/ftp/ftp_directory_listing_parser.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // files is character encoding: 149 // files is character encoding:
150 {"dir-listing-ls-25", OK}, // UTF-8 150 {"dir-listing-ls-25", OK}, // UTF-8
151 {"dir-listing-ls-26", OK}, // KOI8-R 151 {"dir-listing-ls-26", OK}, // KOI8-R
152 {"dir-listing-ls-27", OK}, // windows-1251 152 {"dir-listing-ls-27", OK}, // windows-1251
153 153
154 {"dir-listing-ls-28", OK}, // Hylafax FTP server 154 {"dir-listing-ls-28", OK}, // Hylafax FTP server
155 {"dir-listing-ls-29", OK}, 155 {"dir-listing-ls-29", OK},
156 {"dir-listing-ls-30", OK}, 156 {"dir-listing-ls-30", OK},
157 {"dir-listing-ls-31", OK}, 157 {"dir-listing-ls-31", OK},
158 {"dir-listing-ls-32", OK}, // busybox 158 {"dir-listing-ls-32", OK}, // busybox
159 {"dir-listing-ls-33", OK},
159 160
160 {"dir-listing-netware-1", OK}, 161 {"dir-listing-netware-1", OK},
161 {"dir-listing-netware-2", OK}, 162 {"dir-listing-netware-2", OK},
162 {"dir-listing-netware-3", OK}, 163 {"dir-listing-netware-3", OK},
163 {"dir-listing-os2-1", ERR_UNRECOGNIZED_FTP_DIRECTORY_LISTING_FORMAT}, 164 {"dir-listing-os2-1", ERR_UNRECOGNIZED_FTP_DIRECTORY_LISTING_FORMAT},
164 {"dir-listing-vms-1", OK}, 165 {"dir-listing-vms-1", OK},
165 {"dir-listing-vms-2", OK}, 166 {"dir-listing-vms-2", OK},
166 {"dir-listing-vms-3", OK}, 167 {"dir-listing-vms-3", OK},
167 {"dir-listing-vms-4", OK}, 168 {"dir-listing-vms-4", OK},
168 {"dir-listing-vms-5", OK}, 169 {"dir-listing-vms-5", OK},
169 {"dir-listing-vms-6", OK}, 170 {"dir-listing-vms-6", OK},
170 {"dir-listing-vms-7", OK}, 171 {"dir-listing-vms-7", OK},
171 {"dir-listing-vms-8", OK}, 172 {"dir-listing-vms-8", OK},
172 {"dir-listing-windows-1", OK}, 173 {"dir-listing-windows-1", OK},
173 {"dir-listing-windows-2", OK}, 174 {"dir-listing-windows-2", OK},
174 }; 175 };
175 176
176 INSTANTIATE_TEST_CASE_P(, 177 INSTANTIATE_TEST_CASE_P(,
177 FtpDirectoryListingParserTest, 178 FtpDirectoryListingParserTest,
178 testing::ValuesIn(kTestParams), 179 testing::ValuesIn(kTestParams),
179 TestName); 180 TestName);
180 181
181 } // namespace 182 } // namespace
182 183
183 } // namespace net 184 } // namespace net
OLDNEW
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_ls.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698