Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1451933005: Use correct native theme for StyledLabel labels and links. (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
lgarron, sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct native theme for StyledLabel labels and links. BUG=556772 Committed: https://crrev.com/893bf6a5ad8efee51a01b2d4fe1b09d4709165be Cr-Commit-Position: refs/heads/master@{#360432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ui/views/controls/styled_label.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Evan Stade
This patch is really simple, but I can't actually test it because I can't find ...
5 years, 1 month ago (2015-11-18 01:45:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451933005/1
5 years, 1 month ago (2015-11-18 01:48:56 UTC) #4
lgarron
On 2015/11/18 at 01:48:56, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
5 years, 1 month ago (2015-11-18 01:58:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 02:36:36 UTC) #7
Evan Stade
On 2015/11/18 01:58:19, lgarron wrote: > On 2015/11/18 at 01:48:56, commit-bot wrote: > > Dry ...
5 years, 1 month ago (2015-11-18 22:02:49 UTC) #8
sadrul
lgtm
5 years, 1 month ago (2015-11-18 22:04:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451933005/1
5 years, 1 month ago (2015-11-18 22:18:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 22:41:03 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:41:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/893bf6a5ad8efee51a01b2d4fe1b09d4709165be
Cr-Commit-Position: refs/heads/master@{#360432}

Powered by Google App Engine
This is Rietveld 408576698