Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1451913002: update iOS build flags (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update iOS build flags This makes it match OS X build more closely. The most important change is that CLANG_CXX_LIBRARY sets -stdlib=libc++ for both the compiler and the linker. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1e5cbf2af7c1b818ba98e8a9da351aecfee320cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 1 month ago (2015-11-16 22:06:35 UTC) #2
stephana
On 2015/11/16 22:06:35, mtklein_C wrote: lgtm
5 years, 1 month ago (2015-11-16 22:37:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451913002/1
5 years, 1 month ago (2015-11-16 22:37:40 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 00:20:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e5cbf2af7c1b818ba98e8a9da351aecfee320cb

Powered by Google App Engine
This is Rietveld 408576698