Issue 1451893002: If analysis is already complete, don't start it again in onFileAnalysisComplete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1451893002: If analysis is already complete, don't start it again in onFileAnalysisComplete(). (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

If analysis is already complete, don't start it again in onFileAnalysisComplete(). This should fix the first two problems you found yesterday in the IDEA / DAS log - start/stop analysis on analysis.getErrors and as a consequence an extra analysis.implemented notification. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c29541085288d282fd3ed1563776decaa87933ff

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

5 years, 1 month ago (2015-11-16 22:00:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c29541085288d282fd3ed1563776decaa87933ff (presubmit successful).