third_party/WebKit/Source/core/paint/GridPainter.cpp - Issue 1451883002: [css-grid] Store lines instead of tracks in GridResolvedPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/GridPainter.cpp

Issue 1451883002: [css-grid] Store lines instead of tracks in GridResolvedPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutGrid.cpp ('k') | third_party/WebKit/Source/core/style/GridCoordinate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/GridPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/GridPainter.cpp b/third_party/WebKit/Source/core/paint/GridPainter.cpp

index 4860e06f4ea8e6a3ccf0e3faf5847d6cc8eed111..c029941c40bb600a8afc5a8d9f1c71ea113e1a18 100644

--- a/third_party/WebKit/Source/core/paint/GridPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/GridPainter.cpp

@@ -24,7 +24,8 @@ static GridSpan dirtiedGridAreas(const Vector<LayoutUnit>& coordinates, LayoutUn

if (endGridAreaIndex > 0)

--endGridAreaIndex;

- return GridSpan(startGridAreaIndex, endGridAreaIndex);

+ // GridSpan stores lines' indexes (not tracks' indexes).

+ return GridSpan(startGridAreaIndex, endGridAreaIndex + 1);

}

class GridItemsSorter {