Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 145173010: drive: Merge ContentUpdatePerformer to EntryUpdatePerformer (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, haitaol+watch_chromium.org, oshima+watch_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Merge ContentUpdatePerformer to EntryUpdatePerformer Add UploadExistingFileOptions argument to JobScheduler. Remove UPLOAD SyncType. Merge ContentUpdatePerformer to EntryUpdatePerformer. Pass metadata arguments to JobScheduler::UploadExistingFile(). BUG=337083 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246906

Patch Set 1 : git mv content_update_performer_unittest.cc entry_update_performer_unittest.cc #

Patch Set 2 : please review this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -740 lines) Patch
M chrome/browser/chromeos/drive/job_scheduler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/content_update_performer.h View 1 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/content_update_performer.cc View 1 1 chunk +0 lines, -206 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/content_update_performer_unittest.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.h View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 8 chunks +117 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 1 3 chunks +270 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 1 5 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 1 11 chunks +18 lines, -80 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Please review. 270 lines added to entry_update_performer_unittest.cc is essentially moved from content_update_performer_unittest.cc
6 years, 11 months ago (2014-01-24 05:30:10 UTC) #1
kinaba
lgtm
6 years, 11 months ago (2014-01-24 07:21:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/145173010/110001
6 years, 11 months ago (2014-01-24 09:17:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251201
6 years, 11 months ago (2014-01-24 11:09:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/145173010/110001
6 years, 11 months ago (2014-01-24 11:10:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251257
6 years, 11 months ago (2014-01-24 13:46:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/145173010/110001
6 years, 11 months ago (2014-01-24 14:38:16 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 16:44:30 UTC) #8
Message was sent while issue was closed.
Change committed as 246906

Powered by Google App Engine
This is Rietveld 408576698