[proxies] Wire up Object.getOwnPropertyDescriptor

[proxies] Wire up Object.getOwnPropertyDescriptor

using the new JSReceiver::GetOwnPropertyDescriptor implementation.

BUG=v8:1543
LOG=n
R=cbruni@chromium.org

Committed: https://crrev.com/9c35e4b23ce631013376a11b8c27d3cb86850fd8
Cr-Commit-Position: refs/heads/master@{#32037}

[Jakob Kummerow, 2015-11-16 15:43:29]

PTAL.

[Camillo Bruni, 2015-11-16 16:15:40]

LGTM with nits.

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
File test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js (right):

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:21:
Object.defineProperty(target, "nonconfigurable", nonconfigurable_desc);
I'd repeat this exact test with an empty proxy: new Proxy(target, {}), same
above

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:42: // Checking
basic functionality:
Maybe this is too much work... I tried to order the test according to the checks
in the spec, makes it a bit easier to find missing cases.

Missing cases (probably should check test262): 
- trap is not a callable (ES6 7.3.9)
- trapResult == undefined

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:63:
assertThrows('Object.getOwnPropertyDescriptor(proxy, "nonconfigurable")');
please add a comment why this should throw, I end up in
IsCompatiblePropertyDescriptor where we would return true because there is no
property 456 on the target => current = undefined.

[Jakob Kummerow, 2015-11-17 12:42:51]

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
File test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js (right):

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:21:
Object.defineProperty(target, "nonconfigurable", nonconfigurable_desc);
On 2015/11/16 16:15:40, cbruni wrote:
> I'd repeat this exact test with an empty proxy: new Proxy(target, {}), same
> above

This isn't a test... I guess you mean lines 44/46. Done.

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:42: // Checking
basic functionality:
On 2015/11/16 16:15:40, cbruni wrote:
> Maybe this is too much work... I tried to order the test according to the
checks
> in the spec, makes it a bit easier to find missing cases.

Done, added a third section that specifically triggers each bailout.

> Missing cases (probably should check test262): 
> - trap is not a callable (ES6 7.3.9)

Testcase added.

> - trapResult == undefined

See lines 56ff, 69ff.

https://codereview.chromium.org/1451703003/diff/1/test/mjsunit/harmony/proxy/...
test/mjsunit/harmony/proxy/proxy-getOwnPropertyDescriptor.js:63:
assertThrows('Object.getOwnPropertyDescriptor(proxy, "nonconfigurable")');
On 2015/11/16 16:15:40, cbruni wrote:
> please add a comment why this should throw, I end up in
> IsCompatiblePropertyDescriptor where we would return true because there is no
> property 456 on the target => current = undefined.

Done. (It throws because nonconfigurable properties can't be reported as
configurable.)

[Jakob Kummerow, 2015-11-17 12:50:02]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-11-17 12:50:02]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1451703003/#ps40001
(title: "moved test file")

[commit-bot: I haz the power, 2015-11-17 12:50:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451703003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451703003/40001

[commit-bot: I haz the power, 2015-11-17 13:08:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-17 13:09:03]

Patchset 3 (id:??) landed as
https://crrev.com/9c35e4b23ce631013376a11b8c27d3cb86850fd8
Cr-Commit-Position: refs/heads/master@{#32037}