Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1451603002: X87: [builtins] One runtime fallback is enough for the String constructor. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] One runtime fallback is enough for the String constructor. port 34b7b21d1d7bf2e9c77ae5726f868e69f3b4a4f3 (r32000) original commit message: If inline allocation fails, we can just use the %NewObject fallback, which will do the right thing. We don't need a dedicated fallback to %AllocateInNewSpace. BUG= Committed: https://crrev.com/43ef9bc63241a3c80a5650427ee7a213405cef24 Cr-Commit-Position: refs/heads/master@{#32002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -37 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +18 lines, -37 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-16 03:18:01 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-16 04:15:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451603002/1
5 years, 1 month ago (2015-11-16 04:15:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 04:33:14 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 04:33:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43ef9bc63241a3c80a5650427ee7a213405cef24
Cr-Commit-Position: refs/heads/master@{#32002}

Powered by Google App Engine
This is Rietveld 408576698