Remove OS(IOS) and OS(MAC_OS_X) guards.

Remove OS(IOS) and OS(MAC_OS_X) guards.

OS(IOS) is not supported.
OS(MAC_OS_X) is replaced with OS(DARWIN).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149291

[lgombos, 2013-04-26 17:17:04]

more cleanup.. I choose to keep OS(DARWIN) as that was most widely used in the
code base.

[eseidel, 2013-04-26 18:04:45]

I'm not sure this distinction has much use anymore, but these defines are
different.
Darwin is everything below the UI, and would include things which might work on
iOS too.
MAC_OS_X is code which uses OS X specific UI layers.
iOS is I think a more general define for iOS.

Seems we should at least simplify to MAC/IOS.  I'm not sure what the status of
"DARWIN" as a valid assumption on IOS is.

[lgombos, 2013-04-26 18:26:03]

On 2013/04/26 18:04:45, Eric Seidel (Google) wrote:
> I'm not sure this distinction has much use anymore, but these defines are
> different.
> Darwin is everything below the UI, and would include things which might work
on
> iOS too.
> MAC_OS_X is code which uses OS X specific UI layers.
> iOS is I think a more general define for iOS.
> 
> Seems we should at least simplify to MAC/IOS.  I'm not sure what the status of
> "DARWIN" as a valid assumption on IOS is.

Thanks Eric.

I made an assumption that blink does not target OS(IOS). If this assumption is
not correct than this patch does not make much sense as it is.

I think we need to clarify if OS(IOS) is a target platform for blink before we
can proceed discussing this CL.

[eseidel, 2013-04-27 06:54:17]

OS(MAC_OS_X) has existed forever.  It is supposed to guard Cocoa-level code. 
Code which would not be present on a truly DARWIN system.  I don't know when
OS(IOS) was introduced, but presumably during the (ongoing) IOS upstreaming.

[Avi (use Gerrit), 2013-04-27 15:22:00]

On 2013/04/27 06:54:17, Eric Seidel (Google) wrote:
> OS(MAC_OS_X) has existed forever.  It is supposed to guard Cocoa-level code. 
> Code which would not be present on a truly DARWIN system.  I don't know when
> OS(IOS) was introduced, but presumably during the (ongoing) IOS upstreaming.

I'm pretty sure I've seen DARWIN guard Cocoa-level code. If this is a
distinction we want to keep, then we should. If not... shrug.

[lgombos, 2013-04-27 17:23:56]

On 2013/04/27 15:22:00, Avi wrote:
> On 2013/04/27 06:54:17, Eric Seidel (Google) wrote:
> > OS(MAC_OS_X) has existed forever.  It is supposed to guard Cocoa-level code.

> > Code which would not be present on a truly DARWIN system.  I don't know when
> > OS(IOS) was introduced, but presumably during the (ongoing) IOS upstreaming.
> 
> I'm pretty sure I've seen DARWIN guard Cocoa-level code. If this is a
> distinction we want to keep, then we should. If not... shrug.

I just wanted to add that it might be that there is a better name for the single
guard than OS(DARWIN). This CL focuses on cutting down the number of guards
used, not necessary picking the best name. If it makes the intent of the guard
more clear, we should rename OS(DARWIN) to something else - e.g. OS(MAC) - as a
follow-up CL.

[eseidel, 2013-04-27 19:13:05]

lgtm.

+1 for renaming this OS(MAC) instead of OS(DARWIN).

[Avi (use Gerrit), 2013-04-27 19:32:29]

On 2013/04/27 19:13:05, Eric Seidel (Google) wrote:
> lgtm.
> 
> +1 for renaming this OS(MAC) instead of OS(DARWIN).

In an ideal world, we would audit all of OS(DARWIN) to see if it's actually
OS(MAC).

[lgombos, 2013-04-28 04:21:38]

> > +1 for renaming this OS(MAC) instead of OS(DARWIN).

Will do in a follow-up CL. I looked around and it seems that the chromium code
is uses MACOSX instead of just MAC.

> In an ideal world, we would audit all of OS(DARWIN) to see if it's actually
> OS(MAC).

This would mean that we should also test such a configuration, which in practice
means a bot where OS(DARWIN) is set but OS(MAC) is not set. I am not aware of
such a bot.

[eseidel, 2013-04-28 08:03:23]

OpenDarwin is dead.  And Blink does not support non-Mac OS X Darwin setups.  If
we have some eventual iOS port then we can add things like this back.

I think we should just move to OS(MAC) and add back an OS(DARWIN) if we ever
need it in the future.

[commit-bot: I haz the power, 2013-04-28 15:42:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14516007/1

[commit-bot: I haz the power, 2013-04-28 16:23:50]

Change committed as 149291