Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 145153002: Make sideloaded (externally installed) extensions display webstore info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeOS fix Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 98e0b2573814c0f95746793fe4d944678731ad0a..85ab0f671a015b39492bae057fc9e53449e07e77 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -89,10 +89,10 @@ class ExtensionInstallPrompt
void SetIsShowingDetails(DetailsType type,
size_t index,
bool is_showing_details);
- void SetInlineInstallWebstoreData(const std::string& localized_user_count,
- bool show_user_count,
- double average_rating,
- int rating_count);
+ void SetWebstoreData(const std::string& localized_user_count,
+ bool show_user_count,
+ double average_rating,
+ int rating_count);
void SetOAuthIssueAdvice(const IssueAdviceInfo& issue_advice);
void SetUserNameFromProfile(Profile* profile);
@@ -155,10 +155,11 @@ class ExtensionInstallPrompt
const gfx::Image& icon() const { return icon_; }
void set_icon(const gfx::Image& icon) { icon_ = icon; }
+ bool has_webstore_data() const { return has_webstore_data_; }
+
const ExtensionInstallPromptExperiment* experiment() const {
return experiment_;
}
-
void set_experiment(ExtensionInstallPromptExperiment* experiment) {
experiment_ = experiment;
}
@@ -202,6 +203,10 @@ class ExtensionInstallPrompt
// false if localized_user_count_ represents the number zero).
bool show_user_count_;
+ // Whether or not this prompt has been populated with data from the
+ // webstore.
+ bool has_webstore_data_;
+
std::vector<base::FilePath> retained_files_;
scoped_refptr<ExtensionInstallPromptExperiment> experiment_;
@@ -327,7 +332,8 @@ class ExtensionInstallPrompt
virtual void ConfirmExternalInstall(
Delegate* delegate,
const extensions::Extension* extension,
- const ShowDialogCallback& show_dialog_callback);
+ const ShowDialogCallback& show_dialog_callback,
+ const Prompt& prompt);
// This is called by the extension permissions API to verify whether an
// extension may be granted additional permissions.
« no previous file with comments | « chrome/browser/chromeos/file_manager/app_installer.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698