chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 145153002: Make sideloaded (externally installed) extensions display webstore info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 145153002: Make sideloaded (externally installed) extensions display webstore info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('K') | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 23c497b74d1837e4db2f447881f7deba97f5ca7e..6089cef55d7fb21a593c11b93534a1dfa523e304 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -554,7 +554,7 @@ ExtensionInstallDialogView::ExtensionInstallDialogView(

if (prompt.experiment()->show_checkboxes())

dialog_width += 4 * views::kPanelHorizMargin;

- if (is_inline_install()) {

+ if (prompt.has_webstore_data()) {

layout->StartRow(0, column_set_id);

views::View* rating = new views::View();

rating->SetLayoutManager(new views::BoxLayout(