Make sideloaded (externally installed) extensions display webstore info

chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <gtk/gtk.h>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bundle_installer.h"
@@ skipping 98 matching lines @@
     ExtensionInstallPrompt::Delegate *delegate,
     const ExtensionInstallPrompt::Prompt& prompt)
     : navigator_(show_params.navigator),
       delegate_(delegate),
       dialog_(NULL) {
   bool show_permissions = prompt.ShouldShowPermissions();
   bool show_oauth_issues = prompt.GetOAuthIssueCount() > 0;
   bool show_retained_files = prompt.GetRetainedFileCount() > 0;
   bool is_inline_install =
       prompt.type() == ExtensionInstallPrompt::INLINE_INSTALL_PROMPT;
+  bool has_webstore_data = prompt.has_webstore_data();
   bool is_bundle_install =
       prompt.type() == ExtensionInstallPrompt::BUNDLE_INSTALL_PROMPT;
   bool is_external_install =
       prompt.type() == ExtensionInstallPrompt::EXTERNAL_INSTALL_PROMPT;
 
   if (is_inline_install)
     extension_id_ = prompt.extension()->id();
 
   // Build the dialog.
   gfx::NativeWindow parent = show_params.parent_window;
@@ skipping 62 matching lines @@
   gtk_box_pack_start(GTK_BOX(left_column_area), heading_vbox, center_heading,
                      center_heading, 0);
 
   // Heading
   GtkWidget* heading_label = gtk_util::CreateBoldLabel(
       base::UTF16ToUTF8(prompt.GetHeading().c_str()));
   gtk_util::SetLabelWidth(heading_label, left_column_min_width);
   gtk_box_pack_start(GTK_BOX(heading_vbox), heading_label, center_heading,
                      center_heading, 0);
 
-  if (is_inline_install) {
+  if (has_webstore_data) {

[Finnur, 2014/01/24 11:38:31]

I only see a unit test change on Mac. Is there an additional file for Mac
missing with a change similar to this?

[Devlin, 2014/01/24 18:10:24]

Whoops, yes there is.  Thanks! :)

     // Average rating (as stars) and number of ratings.
     GtkWidget* stars_hbox = gtk_hbox_new(FALSE, 0);
     gtk_box_pack_start(GTK_BOX(heading_vbox), stars_hbox, FALSE, FALSE, 0);
     prompt.AppendRatingStars(AddResourceIcon, stars_hbox);
     GtkWidget* rating_label = gtk_label_new(base::UTF16ToUTF8(
         prompt.GetRatingCount()).c_str());
     gtk_util::ForceFontSizePixels(rating_label, kRatingTextSize);
     gtk_box_pack_start(GTK_BOX(stars_hbox), rating_label,
                        FALSE, FALSE, 3);
 
@@ skipping 220 matching lines @@
   new chrome::ExtensionInstallDialog(show_params, delegate, prompt);
 }
 
 }  // namespace
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }