Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1451423002: [turbofan] Fix several OSR entries within literals. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix several OSR entries within literals. With do-expressions any expression used within literals can turn into an OSR entry-point. This means the literal object being constructed is then renamed to an OSR value and needs to be reloaded from the environment. R=rossberg@chromium.org TEST=mjsunit/regress/regress-osr-in-literal Committed: https://crrev.com/f8a7236119fe7290a09e9656b844c185b5e7feb9 Cr-Commit-Position: refs/heads/master@{#32047}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Skip ignition. #

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M src/compiler/ast-graph-builder.cc View 6 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-osr-in-literal.js View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-17 12:53:32 UTC) #1
Michael Starzinger
Andreas: PTAL. Caitlin: FYI.
5 years, 1 month ago (2015-11-17 13:16:09 UTC) #3
rossberg
LGTM. As discussed off-line, class literals can be a follow-up. https://codereview.chromium.org/1451423002/diff/1/test/mjsunit/regress/regress-osr-in-literal.js File test/mjsunit/regress/regress-osr-in-literal.js (right): https://codereview.chromium.org/1451423002/diff/1/test/mjsunit/regress/regress-osr-in-literal.js#newcode10 ...
5 years, 1 month ago (2015-11-17 13:21:13 UTC) #4
Michael Starzinger
https://codereview.chromium.org/1451423002/diff/1/test/mjsunit/regress/regress-osr-in-literal.js File test/mjsunit/regress/regress-osr-in-literal.js (right): https://codereview.chromium.org/1451423002/diff/1/test/mjsunit/regress/regress-osr-in-literal.js#newcode10 test/mjsunit/regress/regress-osr-in-literal.js:10: { s:"[1, ...[2], do { _OSR_ 3 }, 4]", ...
5 years, 1 month ago (2015-11-17 13:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451423002/40001
5 years, 1 month ago (2015-11-17 14:22:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 14:24:58 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:25:38 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8a7236119fe7290a09e9656b844c185b5e7feb9
Cr-Commit-Position: refs/heads/master@{#32047}

Powered by Google App Engine
This is Rietveld 408576698