Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1451413002: base: Remove deprecated CaseInsensitiveCompareDeprecated struct. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove deprecated CaseInsensitiveCompareDeprecated struct. All deprecated usage has been updated by brettw so this is now unused and thus can be removed. BUG=24917 R=thestig@chromium.org Committed: https://crrev.com/4050a6e4855ab1dfd88dc9bfda298c46773f1697 Cr-Commit-Position: refs/heads/master@{#360132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M base/strings/string_util.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
Lei, PTAL. Brett, fyi.
5 years, 1 month ago (2015-11-17 12:34:53 UTC) #1
Lei Zhang
Woohoo, lgtm!
5 years, 1 month ago (2015-11-17 19:32:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451413002/1
5 years, 1 month ago (2015-11-17 19:34:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 19:44:51 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:48:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4050a6e4855ab1dfd88dc9bfda298c46773f1697
Cr-Commit-Position: refs/heads/master@{#360132}

Powered by Google App Engine
This is Rietveld 408576698