Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1451373003: Revert of Experimental support for RegExp lookbehind. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Experimental support for RegExp lookbehind. (patchset #18 id:340001 of https://codereview.chromium.org/1418963009/ ) Reason for revert: gc stress breaks due to string_start_minus_one not being set correctly. Original issue's description: > Experimental support for RegExp lookbehind. > > R=erikcorry@chromium.org, littledan@chromium.org > BUG=v8:4545 > LOG=N > > Committed: https://crrev.com/37632606bbce1418238b13fd90cb6ef6705871cd > Cr-Commit-Position: refs/heads/master@{#32029} TBR=littledan@chromium.org,erikcorry@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4545 Committed: https://crrev.com/5b2ae9d9088d64a8060f87c315e066b973e7009e Cr-Commit-Position: refs/heads/master@{#32032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -1143 lines) Patch
M src/ast.h View 6 chunks +13 lines, -23 lines 0 comments Download
M src/ast.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parser.h View 6 chunks +6 lines, -18 lines 0 comments Download
M src/parser.cc View 8 chunks +41 lines, -83 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.cc View 15 chunks +53 lines, -97 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 15 chunks +44 lines, -88 lines 0 comments Download
M src/regexp/bytecodes-irregexp.h View 1 chunk +9 lines, -11 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 16 chunks +52 lines, -86 lines 0 comments Download
M src/regexp/interpreter-irregexp.cc View 5 chunks +33 lines, -46 lines 0 comments Download
M src/regexp/jsregexp.h View 12 chunks +27 lines, -32 lines 0 comments Download
M src/regexp/jsregexp.cc View 38 chunks +96 lines, -105 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.cc View 14 chunks +50 lines, -94 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.h View 3 chunks +6 lines, -8 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 16 chunks +46 lines, -84 lines 0 comments Download
M src/regexp/regexp-macro-assembler.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.cc View 3 chunks +14 lines, -18 lines 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.cc View 17 chunks +55 lines, -86 lines 0 comments Download
M test/cctest/test-regexp.cc View 12 chunks +16 lines, -43 lines 0 comments Download
D test/mjsunit/harmony/regexp-lookbehind.js View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Experimental support for RegExp lookbehind.
5 years, 1 month ago (2015-11-17 11:54:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451373003/1
5 years, 1 month ago (2015-11-17 11:54:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 11:55:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b2ae9d9088d64a8060f87c315e066b973e7009e Cr-Commit-Position: refs/heads/master@{#32032}
5 years, 1 month ago (2015-11-17 11:55:29 UTC) #4
erikcorry
5 years, 1 month ago (2015-11-17 12:51:23 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698