Implement GpuArcVideoService for arc video accelerator

components/arc/arc_bridge_service_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_bridge_service_impl.h"
 
 #include <string>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/sequenced_task_runner.h"
 #include "base/task_runner_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_method_call_status.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
+#include "ipc/ipc_channel_handle.h"
 #include "mojo/public/cpp/bindings/array.h"
 #include "third_party/mojo/src/mojo/edk/embedder/embedder.h"
 
 namespace mojo {
 
 template <>
 struct TypeConverter<arc::AppInfo, arc::AppInfoPtr> {
   static arc::AppInfo Convert(const arc::AppInfoPtr& app_info_ptr) {
     return *app_info_ptr;
   }
@@ skipping 123 matching lines @@
                                           ScaleFactor scale_factor) {
   DCHECK(CalledOnValidThread());
   if (state() != State::READY) {
     LOG(ERROR) << "Called RequestAppIcon when the service is not ready";
     return false;
   }
   instance_ptr_->RequestAppIcon(package, activity, scale_factor);
   return true;
 }
 
+bool ArcBridgeServiceImpl::NotifyVideoAcceleratorChannelCreated(
+    const IPC::ChannelHandle& handle) {

[Pawel Osciak, 2015/12/16 10:17:58]

Do we need to verify that handle is not IPC::ChannelHandle() created by
~GpuArcVideoServiceHost()?

[kcwu, 2015/12/16 14:05:32]

Why? Both ArcBridgeServiceImpl and GpuArcVideoServiceHost are in trusted browser
process.

[Pawel Osciak, 2015/12/23 06:24:01]

Yes, but if creation failed we may get an empty handle here, do we need to check
for that?

[kcwu, 2015/12/23 09:09:43]

No, I want to let the remote caller handle the failure.

Looks like the handle could be empty. I found existing code may do that.
https://code.google.com/p/chromium/codesearch#chromium/src/components/font_se...

I will double check after my code works.

+  DCHECK(CalledOnValidThread());
+  if (state() != State::READY) {
+    LOG(ERROR) << "Called NotifyVideoAcceleratorChannelCreated when the "
+                  "service is not ready";
+    return false;
+  }
+  // TODO revisit before commit:
+  // will the handle be closed exactly once?
+  // can mojo create wrapper for invalid handle?
+  MojoHandle wrapped_handle;
+  MojoResult wrap_result = mojo::embedder::CreatePlatformHandleWrapper(
+      mojo::embedder::ScopedPlatformHandle(
+          mojo::embedder::PlatformHandle(handle.socket.fd)),
+      &wrapped_handle);
+  if (wrap_result != MOJO_RESULT_OK) {
+    LOG(WARNING) << "Pipe failed to wrap handles. Closing: " << wrap_result;
+    // Defer closing task to the ScopedFD.
+    base::ScopedFD(handle.socket.fd);
+    return false;

[Pawel Osciak, 2015/12/16 10:17:58]

Do we need to close also before returning from l.170?

[kcwu, 2015/12/16 14:05:32]

No need to close since it is already wrapped into scoper in line 177. Line 183
is removed.

+  }
+  instance_ptr_->NotifyVideoAcceleratorChannelCreated(
+      mojo::ScopedHandle(mojo::Handle(wrapped_handle)));
+  return true;
+}
+
 void ArcBridgeServiceImpl::OnInstanceBootPhase(InstanceBootPhase phase) {
   DCHECK(CalledOnValidThread());
   // The state can be CONNECTED the first time this is called, and will then
   // transition to READY after BRIDGE_READY has been passed.
   if (state() != State::CONNECTED && state() != State::READY) {
     VLOG(1) << "StopInstance() called while connecting";
     return;
   }
   if (phase == INSTANCE_BOOT_PHASE_BRIDGE_READY) {
     SetState(State::READY);
@@ skipping 35 matching lines @@
   // TODO(ejcaruso): Implement.
   VLOG(1) << "OnAcquireDisplayWakeLock";
 }
 
 void ArcBridgeServiceImpl::OnReleaseDisplayWakeLock(DisplayWakeLockType type) {
   DCHECK(CalledOnValidThread());
   // TODO(ejcaruso): Implement.
   VLOG(1) << "OnReleaseDisplayWakeLock";
 }
 
+void ArcBridgeServiceImpl::OnRequestArcVideoAcceleratorChannel() {
+  DCHECK(CalledOnValidThread());
+  FOR_EACH_OBSERVER(VideoServiceObserver, video_service_observer_list(),
+                    OnRequestArcVideoAcceleratorChannel());
+}
+
 void ArcBridgeServiceImpl::OnArcAvailable(bool arc_available) {
   DCHECK(CalledOnValidThread());
   if (available() == arc_available)
     return;
   SetAvailable(arc_available);
   PrerequisitesChanged();
 }
 
 void ArcBridgeServiceImpl::OnConnectionEstablished(
     ArcBridgeInstancePtr instance) {
@@ skipping 11 matching lines @@
 
   SetState(State::CONNECTED);
 }
 
 void ArcBridgeServiceImpl::OnStopped() {
   DCHECK(CalledOnValidThread());
   SetState(State::STOPPED);
 }
 
 }  // namespace arc