Implement GpuArcVideoService for arc video accelerator

components/arc/arc_bridge_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 #define COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/files/scoped_file.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "components/arc/common/arc_bridge.mojom.h"
 
 namespace base {
 class CommandLine;
 }  // namespace base
 
+namespace IPC {
+class ChannelHandle;
+}  // namespace IPC
+
 namespace arc {
 
 class ArcBridgeBootstrap;
 
 // The Chrome-side service that handles ARC instances and ARC bridge creation.
 // This service handles the lifetime of ARC instances and sets up the
 // communication channel (the ARC bridge) used to send and receive messages.
 class ArcBridgeService {
  public:
   // The possible states of the bridge.  In the normal flow, the state changes
@@ skipping 71 matching lines @@
     // Called whenever ARC sends app icon data for specific scale factor.
     virtual void OnAppIcon(const std::string& package,
                            const std::string& activity,
                            ScaleFactor scale_factor,
                            const std::vector<uint8_t>& icon_png_data) {}
 
    protected:
     virtual ~AppObserver() {}
   };
 
+  // Notifies ARC video service events.
+  class VideoServiceObserver {
+   public:
+    // Called whenever to create video accelerator connection.
+    virtual void OnRequestArcVideoAcceleratorChannel() {}

[Owen Lin, 2015/12/15 03:04:06]

I still don't think we should use the name/pattern "Observer" here.

Observer should be optional to arc_bridge_service and can be multiple. It is
perfect to notify the state change inside the container. But I think, here is
not the case. (What if we add two listeners?) We need exactly ONE "Service" to
handle the request.

Please change it to a service provider, e.g., VideoServiceProvider or simply
VideoService. Also change AddVideoServiceObserver to SetVideoService(...). How
do you think?

[Pawel Osciak, 2015/12/16 10:17:58]

+1, I'd prefer this as well.

[kcwu, 2015/12/16 14:05:32]

Done.

+
+   protected:
+    virtual ~VideoServiceObserver() {}
+  };
+
   virtual ~ArcBridgeService();
 
   // Gets the global instance of the ARC Bridge Service. This can only be
   // called on the thread that this class was created on.
   static ArcBridgeService* Get();
 
   // Return true if ARC has been enabled through a commandline
   // switch.
   static bool GetEnabled(const base::CommandLine* command_line);
 
@@ skipping 10 matching lines @@
   // Shutdown() should be called when the browser is shutting down. This can
   // only be called on the thread that this class was created on.
   virtual void Shutdown() = 0;
 
   // Adds or removes observers. This can only be called on the thread that this
   // class was created on.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
   void AddNotificationObserver(NotificationObserver* observer);
   void RemoveNotificationObserver(NotificationObserver* observer);
+  void AddVideoServiceObserver(VideoServiceObserver* observer);
+  void RemoveVideoServiceObserver(VideoServiceObserver* observer);
 
   // Adds or removes ARC app observers. This can only be called on the thread
   // that this class was created on.
   void AddAppObserver(AppObserver* observer);
   void RemoveAppObserver(AppObserver* observer);
 
   // Gets the current state of the bridge service.
   State state() const { return state_; }
 
   // Gets if ARC is available in this system.
@@ skipping 18 matching lines @@
 
   // Requests to launch an app.
   virtual bool LaunchApp(const std::string& package,
                          const std::string& activity) = 0;
 
   // Requests to load an icon of specific scale_factor.
   virtual bool RequestAppIcon(const std::string& package,
                               const std::string& activity,
                               ScaleFactor scale_factor) = 0;
 
+  virtual bool NotifyVideoAcceleratorChannelCreated(
+      const IPC::ChannelHandle& handle) = 0;
+
  protected:
   ArcBridgeService();
 
   // Changes the current state and notifies all observers.
   void SetState(State state);
 
   // Changes the current availability and notifies all observers.
   void SetAvailable(bool availability);
 
   base::ObserverList<Observer>& observer_list() { return observer_list_; }
   base::ObserverList<NotificationObserver>& notification_observer_list() {
     return notification_observer_list_;
   }
 
   base::ObserverList<AppObserver>& app_observer_list() {
     return app_observer_list_;
   }
 
+  base::ObserverList<VideoServiceObserver>& video_service_observer_list() {
+    return video_service_observer_list_;
+  }
+
   bool CalledOnValidThread();
 
  private:
   friend class ArcBridgeTest;
   FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, Basic);
   FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, Prerequisites);
   FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, ShutdownMidStartup);
 
   base::ObserverList<Observer> observer_list_;
   base::ObserverList<NotificationObserver> notification_observer_list_;
+  base::ObserverList<VideoServiceObserver> video_service_observer_list_;
 
   base::ObserverList<AppObserver> app_observer_list_;
 
   base::ThreadChecker thread_checker_;
 
   // If the ARC instance service is available.
   bool available_;
 
   // The current state of the bridge.
   ArcBridgeService::State state_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeService);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_