Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestInit.cpp

Issue 1451333002: Update comments in Request constructor to explain referrer handling more clearly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/RequestInit.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
index 98b3dea0e168604466591e3dfbf3ed795b65b326..aa04784b2e6c3b7ea0f6db2a14f9d8109b4a2ef8 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
@@ -49,10 +49,9 @@ RequestInit::RequestInit(ExecutionContext* context, const Dictionary& options, E
areAnyMembersSet = areAnyMembersSet || isBodySet;
if (areAnyMembersSet) {
- // If any of init's members are present, unset request's
- // omit-Origin-header flag, set request's referrer to "client",
- // and request's referrer policy to the empty string.
- //
+ // A part of the Request constructor algorithm is performed here. See the
yhirano 2015/11/17 09:31:55 Please wrap comments in 80 columns.
tyoshino (SeeGerritForStatus) 2015/11/18 13:42:51 Done.
+ // comments in the Request constructor code for the detail.
+
// We need to use "about:client" instead of |clientReferrerString|,
// because "about:client" => |clientReferrerString| conversion is done
// in Request::createRequestWithRequestOrString.

Powered by Google App Engine
This is Rietveld 408576698