Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 145133013: External Array renaming and boilerplate scrapping (Closed)

Created:
6 years, 11 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

External Array renaming and boilerplate scrapping Replaced symbolic names with correct JS name (byte -> int8, unsigned int -> uint32 etc). Using macros to scrap the boilerplate BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18835

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+955 lines, -1773 lines) Patch
M include/v8.h View 1 chunk +20 lines, -9 lines 0 comments Download
M src/api.h View 2 chunks +5 lines, -13 lines 0 comments Download
M src/api.cc View 10 chunks +44 lines, -106 lines 1 comment Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +8 lines, -27 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/contexts.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/elements.cc View 10 chunks +87 lines, -284 lines 0 comments Download
M src/elements-kind.h View 3 chunks +13 lines, -13 lines 0 comments Download
M src/elements-kind.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/factory.cc View 1 chunk +5 lines, -25 lines 0 comments Download
M src/heap.h View 1 chunk +23 lines, -23 lines 0 comments Download
M src/heap.cc View 8 chunks +41 lines, -121 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 7 chunks +22 lines, -22 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 20 chunks +122 lines, -111 lines 0 comments Download
M src/objects.cc View 23 chunks +144 lines, -331 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +25 lines, -115 lines 0 comments Download
M src/objects-inl.h View 7 chunks +54 lines, -81 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +29 lines, -93 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M src/runtime.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/runtime.cc View 8 chunks +54 lines, -126 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +25 lines, -24 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 13 chunks +113 lines, -112 lines 0 comments Download
M test/mjsunit/elements-kind.js View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Sven, PTAL - I hope you like it. I had a long and boring flight, ...
6 years, 11 months ago (2014-01-24 05:37:11 UTC) #1
Sven Panne
LGTM with a nit https://codereview.chromium.org/145133013/diff/80001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/145133013/diff/80001/src/api.cc#newcode2377 src/api.cc:2377: if (!obj->IsJSTypedArray()) return false; \ ...
6 years, 11 months ago (2014-01-24 12:42:14 UTC) #2
Dmitry Lomov (no reviews)
6 years, 11 months ago (2014-01-24 16:01:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18835 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698