Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145133008: DevTools: Make getEventListeners() of Console API work for window. (Closed)

Created:
6 years, 11 months ago by aandrey
Modified:
6 years, 11 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: Make getEventListeners() of Console API work for window. BUG=336472 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165726

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Total comments: 2

Patch Set 3 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -34 lines) Patch
M LayoutTests/inspector/console/command-line-api-getEventListeners.html View 1 3 chunks +7 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 2 chunks +17 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 2 6 chunks +18 lines, -9 lines 0 comments Download
M Source/core/events/EventTarget.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aandrey
6 years, 11 months ago (2014-01-23 12:47:38 UTC) #1
caseq
https://codereview.chromium.org/145133008/diff/1/LayoutTests/inspector/console/command-line-api-getEventListeners.html File LayoutTests/inspector/console/command-line-api-getEventListeners.html (right): https://codereview.chromium.org/145133008/diff/1/LayoutTests/inspector/console/command-line-api-getEventListeners.html#newcode45 LayoutTests/inspector/console/command-line-api-getEventListeners.html:45: output("FAIL: object is " + (typeof object)); nit: for ...
6 years, 11 months ago (2014-01-23 15:17:15 UTC) #2
aandrey
https://codereview.chromium.org/145133008/diff/1/LayoutTests/inspector/console/command-line-api-getEventListeners.html File LayoutTests/inspector/console/command-line-api-getEventListeners.html (right): https://codereview.chromium.org/145133008/diff/1/LayoutTests/inspector/console/command-line-api-getEventListeners.html#newcode45 LayoutTests/inspector/console/command-line-api-getEventListeners.html:45: output("FAIL: object is " + (typeof object)); On 2014/01/23 ...
6 years, 11 months ago (2014-01-23 15:19:19 UTC) #3
yurys
https://codereview.chromium.org/145133008/diff/60001/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp File Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (right): https://codereview.chromium.org/145133008/diff/60001/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp#newcode293 Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:293: v8::Handle<v8::Object> window = wrapper->FindInstanceInPrototypeChain(V8Window::domTemplate(info.GetIsolate(), worldTypeInMainThread(info.GetIsolate()))); What if it is ...
6 years, 11 months ago (2014-01-23 15:45:48 UTC) #4
aandrey
https://codereview.chromium.org/145133008/diff/60001/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp File Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (right): https://codereview.chromium.org/145133008/diff/60001/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp#newcode293 Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:293: v8::Handle<v8::Object> window = wrapper->FindInstanceInPrototypeChain(V8Window::domTemplate(info.GetIsolate(), worldTypeInMainThread(info.GetIsolate()))); On 2014/01/23 15:45:49, yurys ...
6 years, 11 months ago (2014-01-24 05:55:28 UTC) #5
yurys
lgtm
6 years, 11 months ago (2014-01-24 07:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/145133008/110001
6 years, 11 months ago (2014-01-24 07:58:56 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 09:29:47 UTC) #8
Message was sent while issue was closed. 
Change committed as 165726

Powered by Google App Engine
This is Rietveld 408576698