Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 145133006: Remove the recalc style timer (Closed)

Created:
6 years, 11 months ago by abarth-chromium
Modified:
6 years, 10 months ago
Reviewers:
eseidel, esprehn, ojan
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the recalc style timer This CL removes the recalc style time and instead drives style recalcuation off of requestAnimationFrame. Previously, the recalc timer might fire in the middle of a frame, which could cause us to recalc style twice: once in the middle of the frame and again just before putting up the frame. Driving recalc using requestAnimationFrame avoids this problem by deferring scheduled recalcs until it's time to put up the frame. BUG=337617 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165988

Patch Set 1 #

Patch Set 2 : Fix device-adapt tests #

Patch Set 3 : rebase #

Patch Set 4 : Revert test #

Patch Set 5 : Fix test #

Total comments: 1

Patch Set 6 : Fixenate some unit tests #

Patch Set 7 : Moar raf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -27 lines) Patch
M LayoutTests/animations/display-none-terminates-animation.html View 1 2 3 4 5 6 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/inspector/layer-tree-model.html View 1 2 3 4 1 chunk +17 lines, -11 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
abarth-chromium
Currently failing three tests: +css3/device-adapt/opera/constrain-009.html expected actual diff pretty diff wdiff text pass +css3/device-adapt/opera/constrain-010.html expected ...
6 years, 11 months ago (2014-01-23 02:33:38 UTC) #1
eseidel
If you're successful here, you can tackle the big burrito with https://codereview.chromium.org/19782002/
6 years, 11 months ago (2014-01-23 04:51:41 UTC) #2
abarth-chromium
On 2014/01/23 04:51:41, eseidel wrote: > If you're successful here, you can tackle the big ...
6 years, 11 months ago (2014-01-23 05:19:10 UTC) #3
abarth-chromium
This CL is ready for review now.
6 years, 11 months ago (2014-01-27 20:34:25 UTC) #4
esprehn
lgtm, amazing. https://codereview.chromium.org/145133006/diff/100004/LayoutTests/inspector/layer-tree-model.html File LayoutTests/inspector/layer-tree-model.html (right): https://codereview.chromium.org/145133006/diff/100004/LayoutTests/inspector/layer-tree-model.html#newcode60 LayoutTests/inspector/layer-tree-model.html:60: InspectorTest.evaluateAndRunWhenTreeChanges("void(0)", function() { Woah, crazy.
6 years, 11 months ago (2014-01-27 20:49:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/100004
6 years, 11 months ago (2014-01-27 21:02:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19184
6 years, 11 months ago (2014-01-27 22:21:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/100005
6 years, 11 months ago (2014-01-28 00:00:26 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=24202
6 years, 11 months ago (2014-01-28 03:09:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/100005
6 years, 11 months ago (2014-01-28 03:50:42 UTC) #10
esprehn
It looks like you may have made virtual/threaded/animations/display-none-terminates-animation.html fail on windows? Not sure how though...
6 years, 11 months ago (2014-01-28 03:51:35 UTC) #11
abarth-chromium
On 2014/01/28 03:51:35, esprehn wrote: > It looks like you may have made > virtual/threaded/animations/display-none-terminates-animation.html ...
6 years, 10 months ago (2014-01-28 04:33:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/150001
6 years, 10 months ago (2014-01-28 05:46:52 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_unit_tests, wtf_unittests ...
6 years, 10 months ago (2014-01-28 07:17:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/150001
6 years, 10 months ago (2014-01-28 07:22:11 UTC) #15
commit-bot: I haz the power
Change committed as 165918
6 years, 10 months ago (2014-01-28 08:32:18 UTC) #16
gavinp
On 2014/01/28 08:32:18, I haz the power (commit-bot) wrote: > Change committed as 165918 I'm ...
6 years, 10 months ago (2014-01-28 14:18:06 UTC) #17
gavinp
On 2014/01/28 14:18:06, gavinp wrote: > On 2014/01/28 08:32:18, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-01-28 14:20:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145133006/150001
6 years, 10 months ago (2014-01-29 02:25:45 UTC) #19
commit-bot: I haz the power
Change committed as 165988
6 years, 10 months ago (2014-01-29 02:26:34 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:28:19 UTC) #21
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698