Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 14513002: Add assertion about module scopes to Scope::ContextChainLength. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add assertion about module scopes to Scope::ContextChainLength. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/scopes.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-26 13:19:23 UTC) #1
rossberg
lgtm
7 years, 8 months ago (2013-04-26 13:20:57 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-26 13:22:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698