Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1451273002: [turbofan] Move JSCallFunction specialization to JSCallReducer. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move JSCallFunction specialization to JSCallReducer. This is the first part to refactoring the JSNativeContextSpecialization class, which has grown way too big recently. Also don't collect cross context feedback for the CallIC in general. Neither TurboFan nor Crankshaft can make any use of cross context JSFunction feedback that is collected by the CallIC, so there's no point in gathering that feedback at all (it just complicates the checking that is necessary in the compilers). What we should do instead at some point (when Crankshaft becomes less important) is to collect the SharedFunctionInfo as feedback for those cases. R=yangguo@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/e5edd66d070952ad4243acf14aa7cc161be7fe18 Cr-Commit-Position: refs/heads/master@{#32022}

Patch Set 1 #

Patch Set 2 : Fix arm64 failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -79 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +19 lines, -1 line 0 comments Download
M src/compiler/js-call-reducer.cc View 5 chunks +101 lines, -18 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-17 06:09:47 UTC) #1
Benedikt Meurer
Hey Yang, Here's an easy one, moving functionality within TurboFan and limiting the scope of ...
5 years, 1 month ago (2015-11-17 06:10:29 UTC) #2
Yang
On 2015/11/17 06:10:29, Benedikt Meurer wrote: > Hey Yang, > > Here's an easy one, ...
5 years, 1 month ago (2015-11-17 06:16:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451273002/20001
5 years, 1 month ago (2015-11-17 06:21:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 07:14:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 07:15:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5edd66d070952ad4243acf14aa7cc161be7fe18
Cr-Commit-Position: refs/heads/master@{#32022}

Powered by Google App Engine
This is Rietveld 408576698