Issue 1451243002: skip task-model only tests if not running with task model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1451243002: skip task-model only tests if not running with task model (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, pquitslund

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	pkg/analyzer/test/generated/resolver_test.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

Phil was running pkg/analyzer/test/all_tests.dart and seeing a failure. It appears to run these tests without ...

5 years, 1 month ago (2015-11-17 02:27:00 UTC) #2

Brian Wilkerson

LGTM. Hopefully we'll be able to delete the added code in a few days.

5 years, 1 month ago (2015-11-17 03:25:52 UTC) #3

Jennifer Messerly

5 years, 1 month ago (2015-11-17 20:37:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f938594bcfc7be35053139e04c0a42789d8ad0f (presubmit successful).