Issue 145123003: Remove an impossible check in QuicConnection for when a packet is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145123003: Remove an impossible check in QuicConnection for when a packet is (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)

Modified:
6 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove an impossible check in QuicConnection for when a packet is retransmitted before it is sent. Updating the tests also found and fixed an edge case where a truncated ack could cause the SentPacketManager to raise the high water mark above a pending packet. Merge internal change: 60169343 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -199 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+6 lines, -19 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	6 chunks	+16 lines, -27 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	8 chunks	+33 lines, -150 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages