Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1451183004: fix ninepatch iter from generating invalid rects (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, egdaniel, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix ninepatch iter from generating invalid rects BUG=skia: Committed: https://skia.googlesource.com/skia/+/3622d417032aff10a0f9f5f9c301272e9804e7ec

Patch Set 1 #

Patch Set 2 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkNinePatchIter.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
not exactly sure how this didn't trigger valgrind issues, but from reading the code it ...
5 years, 1 month ago (2015-11-17 18:58:07 UTC) #2
reed1
lgtm
5 years, 1 month ago (2015-11-17 19:00:03 UTC) #3
joshualitt
5 years, 1 month ago (2015-11-17 19:10:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451183004/20001
5 years, 1 month ago (2015-11-17 19:58:35 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:12:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3622d417032aff10a0f9f5f9c301272e9804e7ec

Powered by Google App Engine
This is Rietveld 408576698