Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1451173002: IPC: Use <algorithm> helpers for comparing arrays (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC: Use <algorithm> helpers for comparing arrays Use std::equal and std::lexicographical_compare for comparing nonce arrays, rather than manual iteration and comparison. R=tsepez@chromium.org Committed: https://crrev.com/cc738251ff93ffcb0cf8e18270fca26e73b8a1df Cr-Commit-Position: refs/heads/master@{#360115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M ipc/brokerable_attachment.h View 2 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jsbell
I just happened to notice these while looking for places where std::tie could make operator< ...
5 years, 1 month ago (2015-11-16 23:32:47 UTC) #1
jsbell
Oh, and explicitly: tsepez@ - please take a look?
5 years, 1 month ago (2015-11-16 23:33:06 UTC) #2
Tom Sepez
I like it. None of these are C++11 library features, right? LGTM otherwise.
5 years, 1 month ago (2015-11-17 17:29:33 UTC) #3
jsbell
On 2015/11/17 17:29:33, Tom Sepez wrote: > I like it. None of these are C++11 ...
5 years, 1 month ago (2015-11-17 17:30:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451173002/1
5 years, 1 month ago (2015-11-17 17:58:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 18:16:44 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 18:17:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc738251ff93ffcb0cf8e18270fca26e73b8a1df
Cr-Commit-Position: refs/heads/master@{#360115}

Powered by Google App Engine
This is Rietveld 408576698