| Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
|
| diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
|
| index 70682c8429abc21d7a1de26c22770d6d941bd428..818b2abca0c246a2e291529d2ed3aa6fdd2a60b3 100644
|
| --- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
|
| +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
|
| @@ -114,10 +114,13 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
| private static class MockCrashReportingPermissionManager
|
| implements CrashReportingPermissionManager {
|
| private final boolean mIsPermitted;
|
| + private final boolean mIsUserPermitted;
|
| private final boolean mIsLimited;
|
|
|
| - MockCrashReportingPermissionManager(boolean isPermitted, boolean isLimited) {
|
| + MockCrashReportingPermissionManager(boolean isPermitted,
|
| + boolean isUserPermitted, boolean isLimited) {
|
| mIsPermitted = isPermitted;
|
| + mIsUserPermitted = isUserPermitted;
|
| mIsLimited = isLimited;
|
| }
|
|
|
| @@ -127,6 +130,11 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
| }
|
|
|
| @Override
|
| + public boolean isUploadUserPermitted() {
|
| + return mIsUserPermitted;
|
| + }
|
| +
|
| + @Override
|
| public boolean isUploadLimited() {
|
| return mIsLimited;
|
| }
|
| @@ -173,7 +181,7 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
| @Feature({"Android-AppBase"})
|
| public void testCallWhenCurrentlyPermitted() throws Exception {
|
| CrashReportingPermissionManager testPermManager =
|
| - new MockCrashReportingPermissionManager(true, false);
|
| + new MockCrashReportingPermissionManager(true, true, false);
|
|
|
| HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
|
|
|
| @@ -187,9 +195,9 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
|
|
| @SmallTest
|
| @Feature({"Android-AppBase"})
|
| - public void testCallPermittedButNotUnderCurrentCircumstances() throws Exception {
|
| + public void testCallNotPermittedByUser() throws Exception {
|
| CrashReportingPermissionManager testPermManager =
|
| - new MockCrashReportingPermissionManager(false, false);
|
| + new MockCrashReportingPermissionManager(false, false, false);
|
|
|
| HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
|
|
|
| @@ -197,6 +205,21 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
| new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
|
| assertEquals(MinidumpUploadCallable.UPLOAD_DISABLED,
|
| minidumpUploadCallable.call().intValue());
|
| + assertTrue(mExpectedFileAfterUpload.exists());
|
| + }
|
| +
|
| + @SmallTest
|
| + @Feature({"Android-AppBase"})
|
| + public void testCallPermittedButNotUnderCurrentCircumstances() throws Exception {
|
| + CrashReportingPermissionManager testPermManager =
|
| + new MockCrashReportingPermissionManager(false, true, false);
|
| +
|
| + HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
|
| +
|
| + MinidumpUploadCallable minidumpUploadCallable =
|
| + new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
|
| + assertEquals(MinidumpUploadCallable.UPLOAD_FAILURE,
|
| + minidumpUploadCallable.call().intValue());
|
| assertFalse(mExpectedFileAfterUpload.exists());
|
| }
|
|
|
| @@ -204,7 +227,7 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
|
| @Feature({"Android-AppBase"})
|
| public void testCrashUploadConstrainted() throws Exception {
|
| CrashReportingPermissionManager testPermManager =
|
| - new MockCrashReportingPermissionManager(true, true);
|
| + new MockCrashReportingPermissionManager(true, true, true);
|
|
|
| HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
|
|
|
|
|