Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4703)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

Issue 1451153002: Schedule retry for user-permitted uploads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo introduction of obsolete code Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashReportingPermissionManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
index 730589fa0a1316de45feacf6539f44d080b91fbb..24ac9c25a858aac06f24dd07776f80d415263dfa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
@@ -38,7 +38,7 @@ import java.util.zip.GZIPOutputStream;
* and false otherwise.
*/
public class MinidumpUploadCallable implements Callable<Integer> {
- private static final String TAG = "cr.MDUploadCallable";
+ private static final String TAG = "MDUploadCallable";
// These preferences are obsolete and are kept only for removing from user preferences.
protected static final String PREF_DAY_UPLOAD_COUNT = "crash_day_dump_upload_count";
@@ -84,13 +84,15 @@ public class MinidumpUploadCallable implements Callable<Integer> {
@Override
public Integer call() {
- if (!mPermManager.isUploadPermitted()) {
- Log.i(TAG, "Minidump upload is not permitted");
+ if (!mPermManager.isUploadUserPermitted()) {
+ Log.i(TAG, "Minidump upload is not permitted by user. Marking file as uploaded for "
+ + "cleanup to prevent future uploads.");
+ cleanupMinidumpFile();
return UPLOAD_DISABLED;
}
boolean isLimited = mPermManager.isUploadLimited();
- if (isLimited) {
+ if (isLimited || !mPermManager.isUploadPermitted()) {
Log.i(TAG, "Minidump cannot currently be uploaded due to constraints.");
return UPLOAD_FAILURE;
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashReportingPermissionManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698