Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1451103005: Revert "Remove obsolete LTR scrollbar padding hack." (Closed)

Created:
5 years, 1 month ago by wkorman
Modified:
5 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove obsolete LTR scrollbar padding hack." Breaks caret rendering at rightmost edge of some situations. This reverts commit 5fdc15a7ec5c12ea3a708796c8cb3338c474f0fa. BUG=548596, 523969 TBR=chrishtr Committed: https://crrev.com/4a57b23cb4eb0a97fa04a7e11c97d5f0b6c15896 Cr-Commit-Position: refs/heads/master@{#360247}

Patch Set 1 #

Patch Set 2 : Updated expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/input/editable-container-with-word-wrap-normal.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451103005/1
5 years, 1 month ago (2015-11-17 22:35:00 UTC) #3
wkorman
5 years, 1 month ago (2015-11-17 22:35:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142056) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 1 month ago (2015-11-17 23:33:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451103005/20001
5 years, 1 month ago (2015-11-17 23:49:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 01:10:10 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 01:11:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a57b23cb4eb0a97fa04a7e11c97d5f0b6c15896
Cr-Commit-Position: refs/heads/master@{#360247}

Powered by Google App Engine
This is Rietveld 408576698