Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1451103004: Handle destroyed tab cases in Reader Mode (Closed)

Created:
5 years, 1 month ago by mdjones
Modified:
5 years ago
Reviewers:
nyquist, wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle destroyed tab cases in Reader Mode There are instances where callbacks and events can be triggered and then the host tab for Reader Mode is destroyed. This change adds checks for these cases. BUG=556930, 556456, 556354 Committed: https://crrev.com/727acaba3508bb21c813a43c213c7e2f5582d95d Cr-Commit-Position: refs/heads/master@{#361168}

Patch Set 1 #

Patch Set 2 : add todo for delegate removal #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 2 3 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
mdjones
PTAL
5 years, 1 month ago (2015-11-17 21:46:53 UTC) #2
wychen
lgtm https://codereview.chromium.org/1451103004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java File chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java (right): https://codereview.chromium.org/1451103004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java#newcode299 chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:299: private WebContentsObserver createWebContentsObserver(WebContents webContents) { Is this only ...
5 years, 1 month ago (2015-11-17 22:04:48 UTC) #3
mdjones
https://codereview.chromium.org/1451103004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java File chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java (right): https://codereview.chromium.org/1451103004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java#newcode299 chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java:299: private WebContentsObserver createWebContentsObserver(WebContents webContents) { On 2015/11/17 22:04:48, wychen ...
5 years, 1 month ago (2015-11-17 22:43:51 UTC) #4
mdjones
+nyquist PTAL
5 years, 1 month ago (2015-11-17 22:45:08 UTC) #6
nyquist
lgtm
5 years, 1 month ago (2015-11-21 00:07:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451103004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451103004/20001
5 years, 1 month ago (2015-11-21 00:15:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/126331) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-21 00:19:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451103004/40001
5 years ago (2015-11-23 19:12:09 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-23 20:19:40 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-23 20:20:30 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/727acaba3508bb21c813a43c213c7e2f5582d95d
Cr-Commit-Position: refs/heads/master@{#361168}

Powered by Google App Engine
This is Rietveld 408576698