Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1451053002: Move paint-order property into CSSPropertyParser (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move paint-order property into CSSPropertyParser Move paint-order property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/5c6599d17ebb019a21c3e4152d83e00ab4cc4c02 Cr-Commit-Position: refs/heads/master@{#360083}

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -63 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 3 chunks +1 line, -61 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-16 21:42:35 UTC) #3
Timothy Loh
On 2015/11/16 21:42:35, rwlbuis wrote: > PTAL. lgtm
5 years, 1 month ago (2015-11-17 02:42:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451053002/20001
5 years, 1 month ago (2015-11-17 14:11:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 16:21:11 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 16:22:46 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5c6599d17ebb019a21c3e4152d83e00ab4cc4c02
Cr-Commit-Position: refs/heads/master@{#360083}

Powered by Google App Engine
This is Rietveld 408576698