Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2359)

Unified Diff: content/renderer/media/rtc_video_decoder_factory.cc

Issue 145103004: Revert of Remove threading from RendererGpuVideoAcceleratorFactories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dthread
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_video_decoder_factory.cc
diff --git a/content/renderer/media/rtc_video_decoder_factory.cc b/content/renderer/media/rtc_video_decoder_factory.cc
index f59a38fa9b3def68bb53db16618a34165f595c5f..9e12803c8278c5bb281e9594d6511bf4d6af1bff 100644
--- a/content/renderer/media/rtc_video_decoder_factory.cc
+++ b/content/renderer/media/rtc_video_decoder_factory.cc
@@ -6,13 +6,13 @@
#include "base/location.h"
#include "base/memory/scoped_ptr.h"
+#include "content/renderer/media/renderer_gpu_video_accelerator_factories.h"
#include "content/renderer/media/rtc_video_decoder.h"
-#include "media/filters/gpu_video_accelerator_factories.h"
namespace content {
RTCVideoDecoderFactory::RTCVideoDecoderFactory(
- const scoped_refptr<media::GpuVideoAcceleratorFactories>& gpu_factories)
+ const scoped_refptr<RendererGpuVideoAcceleratorFactories>& gpu_factories)
: gpu_factories_(gpu_factories) {
DVLOG(2) << "RTCVideoDecoderFactory";
}
@@ -24,8 +24,12 @@
webrtc::VideoDecoder* RTCVideoDecoderFactory::CreateVideoDecoder(
webrtc::VideoCodecType type) {
DVLOG(2) << "CreateVideoDecoder";
+ // GpuVideoAcceleratorFactories is not thread safe. It cannot be shared
+ // by different decoders. This method runs on Chrome_libJingle_WorkerThread
+ // and the child thread is blocked while this runs. We cannot create new gpu
+ // factories here. Clone one instead.
scoped_ptr<RTCVideoDecoder> decoder =
- RTCVideoDecoder::Create(type, gpu_factories_);
+ RTCVideoDecoder::Create(type, gpu_factories_->Clone());
return decoder.release();
}
« no previous file with comments | « content/renderer/media/rtc_video_decoder_factory.h ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698