Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py

Issue 145103003: IRC commit-bot: Make svn revision appear in the beginning of bot message. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/tool/bot/commitannouncer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py
diff --git a/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py b/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py
index f60c35f74c0dd9cdc86b8bcff6f4eab3dd9c6c34..8b8df8ce95ad0498e56fe5b08c7d389a32c4a722 100644
--- a/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py
+++ b/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py
@@ -34,8 +34,7 @@ class CommitAnnouncerTest(unittest.TestCase):
tool = MockTool()
bot = CommitAnnouncer(tool, "test_password")
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789',
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line"',
bot._format_commit_detail("""\
1234commit1234
authorABC@chromium.org
@@ -53,9 +52,8 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'https://chromium.googlesource.com/chromium/blink/+/1234comm '
- 'r456789',
+ 'r456789 https://chromium.googlesource.com/chromium/blink/+/1234comm '
+ 'authorABC@chromium.org committed "Commit test subject line"',
bot._format_commit_detail("""\
1234commit1234
authorABC@chromium.org
@@ -71,8 +69,7 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 ',
+ 'http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line"',
bot._format_commit_detail("""\
1234commit1234
authorABC@chromium.org
@@ -88,8 +85,7 @@ Review URL: https://codereview.chromium.org/123456
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'https://chromium.googlesource.com/chromium/blink/+/1234comm ',
+ 'https://chromium.googlesource.com/chromium/blink/+/1234comm authorABC@chromium.org committed "Commit test subject line"',
bot._format_commit_detail("""\
1234commit1234
authorABC@chromium.org
@@ -101,8 +97,7 @@ description.
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789',
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line"',
bot._format_commit_detail("""\
1234commit1234
authorABC@chromium.org
@@ -122,8 +117,7 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789 '
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line" '
'\x037TBR=reviewerDEF@chromium.org\x03',
bot._format_commit_detail("""\
1234commit1234
@@ -143,8 +137,7 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789 '
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line" '
'\x037NOTRY=true\x03',
bot._format_commit_detail("""\
1234commit1234
@@ -164,8 +157,7 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789 '
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line" '
'\x037NOTRY=true TBR=reviewerDEF@chromium.org\x03',
bot._format_commit_detail("""\
1234commit1234
@@ -186,8 +178,7 @@ git-svn-id: svn://svn.chromium.org/blink/trunk@456789 bbb929c8-8fbe-4397-9dbb-9b
"""))
self.assertEqual(
- 'authorABC@chromium.org committed "Commit test subject line" '
- 'http://crrev.com/123456 r456789 '
+ 'r456789 http://crrev.com/123456 authorABC@chromium.org committed "Commit test subject line" '
'\x037tbr=reviewerDEF@chromium.org, reviewerGHI@chromium.org, reviewerJKL@chromium.org notry=TRUE\x03',
bot._format_commit_detail("""\
1234commit1234
« no previous file with comments | « Tools/Scripts/webkitpy/tool/bot/commitannouncer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698