Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 145103003: IRC commit-bot: Make svn revision appear in the beginning of bot message. (Closed)

Created:
6 years, 10 months ago by vivekg_samsung
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

IRC commit-bot: Make svn revision appear in the beginning of bot message. It is easier to read the svn version quickly if it appears in the beginning of the message. R=alancutter, dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166120

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
Tools/Scripts/webkitpy/tool/bot/commitannouncer.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py View 1 9 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vivekg
PTAL
6 years, 10 months ago (2014-01-29 04:00:35 UTC) #1
vivekg
ping!
6 years, 10 months ago (2014-01-30 03:31:05 UTC) #2
dstockwell
I agree that it makes it easier to read the revision, but I find the ...
6 years, 10 months ago (2014-01-30 04:42:06 UTC) #3
vivekg
On 2014/01/30 04:42:06, dstockwell wrote: > I agree that it makes it easier to read ...
6 years, 10 months ago (2014-01-30 05:05:51 UTC) #4
alancutter (OOO until 2018)
On 2014/01/30 05:05:51, vivekg_ wrote: > On 2014/01/30 04:42:06, dstockwell wrote: > > I agree ...
6 years, 10 months ago (2014-01-30 06:13:21 UTC) #5
vivekg
On 2014/01/30 06:13:21, alancutter wrote: > On 2014/01/30 05:05:51, vivekg_ wrote: > > On 2014/01/30 ...
6 years, 10 months ago (2014-01-30 06:39:01 UTC) #6
alancutter (OOO until 2018)
On 2014/01/30 06:39:01, vivekg_ wrote: > On 2014/01/30 06:13:21, alancutter wrote: > > On 2014/01/30 ...
6 years, 10 months ago (2014-01-30 09:39:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/145103003/20001
6 years, 10 months ago (2014-01-30 09:50:12 UTC) #8
commit-bot: I haz the power
Change committed as 166120
6 years, 10 months ago (2014-01-30 11:11:35 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 11:12:14 UTC) #10
alancutter (OOO until 2018)
6 years, 10 months ago (2014-01-30 21:44:46 UTC) #11
Message was sent while issue was closed.
Running commit-bot instance updated to include this change.

Powered by Google App Engine
This is Rietveld 408576698