Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1451023005: Revert of [Sync] Componentize ProfileSyncComponentsFactoryImpl (Closed)

Created:
5 years, 1 month ago by loyso (OOO)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Componentize ProfileSyncComponentsFactoryImpl (patchset #8 id:180001 of https://codereview.chromium.org/1421003007/ ) Reason for revert: Fails unit tests on Android builds: ProfileSyncServiceFactoryTest.CreatePSSDisableOne ProfileSyncServiceFactoryTest.CreatePSSDisableMultiple ProfileSyncServiceFactoryTest.CreatePSSDefault Original issue's description: > [Sync] Componentize ProfileSyncComponentsFactoryImpl > > Componentize ProfileSyncComponentsFactoryImpl into browser_sync component. > As part of this, pull out RegisterDesktopDatatypes method into ChromeSyncClient. > Similarly, a RegisterAndroidDataTypes is created instead for Android > platforms. > > Because profile_sync_components_factory_impl_unittest.cc was really duplicating > and testing the logic from ProfileSyncServiceFactory, went ahead and moved the > test cases over into profile_sync_service_factory_unittest.cc. > > BUG=512768 > TBR=rdevlin.cronin@chromium.org > > Committed: https://crrev.com/7db382299ca33ffb369f9c79a5331bbfbab259bc > Cr-Commit-Position: refs/heads/master@{#359916} TBR=blundell@chromium.org,rdevlin.cronin@chromium.org,zea@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512768 Committed: https://crrev.com/958471f62fe440dbde14ac8ad0292f0af5da83b3 Cr-Commit-Position: refs/heads/master@{#359988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1007 lines, -1001 lines) Patch
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.h View 4 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 7 chunks +6 lines, -181 lines 0 comments Download
A chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +116 lines, -0 lines 0 comments Download
A chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +554 lines, -0 lines 0 comments Download
A chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 1 chunk +181 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 5 chunks +17 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 2 chunks +5 lines, -110 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 7 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 2 chunks +19 lines, -20 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M components/browser_sync/browser/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M components/browser_sync/browser/DEPS View 1 chunk +1 line, -5 lines 0 comments Download
D components/browser_sync/browser/profile_sync_components_factory_impl.h View 1 chunk +0 lines, -113 lines 0 comments Download
D components/browser_sync/browser/profile_sync_components_factory_impl.cc View 1 chunk +0 lines, -400 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 2 chunks +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 4 chunks +46 lines, -46 lines 0 comments Download
M components/sync_driver/fake_sync_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver/fake_sync_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/sync_api_component_factory.h View 3 chunks +2 lines, -9 lines 0 comments Download
M components/sync_driver/sync_api_component_factory_mock.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync_driver/sync_client.h View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
loyso (OOO)
Created Revert of [Sync] Componentize ProfileSyncComponentsFactoryImpl
5 years, 1 month ago (2015-11-17 03:23:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451023005/1
5 years, 1 month ago (2015-11-17 03:24:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 03:25:48 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 03:26:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/958471f62fe440dbde14ac8ad0292f0af5da83b3
Cr-Commit-Position: refs/heads/master@{#359988}

Powered by Google App Engine
This is Rietveld 408576698