Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1450953002: Revert of Move ScrollAnimatorTest.cpp to Source/platform/scroll/. (Closed)

Created:
5 years, 1 month ago by jbroman
Modified:
5 years, 1 month ago
Reviewers:
Mike West, skobes
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ScrollAnimatorTest.cpp to Source/platform/scroll/. (patchset #2 id:20001 of https://codereview.chromium.org/1438043011/ ) Reason for revert: Fails on Oilpan (leaked mock object). Suspect an explicit GC is required. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/30981/steps/blink_platform_unittests/logs/ScrollAnimatorEnabled.Disabled Original issue's description: > Move ScrollAnimatorTest.cpp to Source/platform/scroll/. > > Some classes in these files were moved into anonymous namespaces, because > otherwise they generated ODR violations by being linked into the same test > binary. (And this manifested as a crash, rather than a compile failure!) > > BUG=353585 > > Committed: https://crrev.com/0a6e1d78456bfaf594c236123081e5f3d457ed9c > Cr-Commit-Position: refs/heads/master@{#359850} TBR=mkwst@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=353585 Committed: https://crrev.com/45549784f2c6b8b94a9dfb9c572ea44654800611 Cr-Commit-Position: refs/heads/master@{#359861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1109 lines, -1115 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 1 chunk +0 lines, -1099 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/ScrollAnimatorTest.cpp View 1 chunk +1095 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
Created Revert of Move ScrollAnimatorTest.cpp to Source/platform/scroll/.
5 years, 1 month ago (2015-11-16 17:47:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450953002/1
5 years, 1 month ago (2015-11-16 17:47:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 17:48:54 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 17:49:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45549784f2c6b8b94a9dfb9c572ea44654800611
Cr-Commit-Position: refs/heads/master@{#359861}

Powered by Google App Engine
This is Rietveld 408576698