Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1450913003: Remove v1 of Startup.FirstWebContents.* stats deprecated in M48. (Closed)

Created:
5 years, 1 month ago by gab
Modified:
5 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@e2_better_ownership_model_firstwebcontentsprofiler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove v1 of Startup.FirstWebContents.* stats deprecated in M48. (to be landed in M49) BUG=544138 Committed: https://crrev.com/ba3840db6ae1e8e3cc1cfa7b763d3c93328c7121 Cr-Commit-Position: refs/heads/master@{#360002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -73 lines) Patch
M chrome/browser/metrics/first_web_contents_profiler.cc View 4 chunks +14 lines, -31 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.h View 1 chunk +0 lines, -10 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1415773004 Patch 160001

Messages

Total messages: 7 (2 generated)
gab
Robert PTAL. (do you think I can land this right after the M48 branch cut ...
5 years, 1 month ago (2015-11-16 19:57:38 UTC) #2
rkaplow
lgtm right after branch cut is fine
5 years, 1 month ago (2015-11-16 20:33:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450913003/1
5 years, 1 month ago (2015-11-17 02:25:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 04:30:46 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 04:31:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ba3840db6ae1e8e3cc1cfa7b763d3c93328c7121
Cr-Commit-Position: refs/heads/master@{#360002}

Powered by Google App Engine
This is Rietveld 408576698