Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 14509012: HasOnlyAsciiChars can return incorrect results. Fixup usages and rename. (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev, tfarina
Visibility:
Public.

Description

HasOnlyAsciiChars can return incorrect results. Fixup usages and rename. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14453

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -121 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -5 lines 1 comment Download
M src/api.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/heap.h View 3 chunks +9 lines, -7 lines 0 comments Download
M src/heap.cc View 1 5 chunks +13 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.h View 1 10 chunks +28 lines, -28 lines 0 comments Download
M src/objects.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcarney
Ulan, HasOnlyAsciiChars actually returns true if a string is only contains one byte characters, and ...
5 years, 9 months ago (2013-04-26 10:51:08 UTC) #1
ulan
LGTM https://chromiumcodereview.appspot.com/14509012/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/14509012/diff/1/src/arm/code-stubs-arm.cc#newcode5953 src/arm/code-stubs-arm.cc:5953: // to contain only one btye characters. typo ...
5 years, 9 months ago (2013-04-26 11:26:44 UTC) #2
dcarney
Committed patchset #2 manually as r14453 (presubmit successful).
5 years, 9 months ago (2013-04-26 11:34:57 UTC) #3
tfarina
https://codereview.chromium.org/14509012/diff/5001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/14509012/diff/5001/include/v8.h#newcode1188 include/v8.h:1188: // TODO(dcarney): deprecate can we use V8_DEPRECATED?
5 years, 9 months ago (2013-04-26 16:31:52 UTC) #4
dcarney
5 years, 9 months ago (2013-04-26 19:30:12 UTC) #5
Message was sent while issue was closed. 
On 2013/04/26 16:31:52, tfarina wrote:
> https://codereview.chromium.org/14509012/diff/5001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/14509012/diff/5001/include/v8.h#newcode1188
> include/v8.h:1188: // TODO(dcarney): deprecate
> can we use V8_DEPRECATED?

Actually, yes, as there don't appear to be any calls in chromium to it.  I'll
follow up.

Powered by Google App Engine
This is Rietveld 408576698