Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1450883003: [turbofan] Check for dead node in the common operator reducer. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Check for dead node in the common operator reducer. BUG=chromium:556543 LOG=n Committed: https://crrev.com/a77f9179e0135afcfe6f62f1451f27517c6b9c61 Cr-Commit-Position: refs/heads/master@{#32025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/compiler/common-operator-reducer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-556543.js View 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Benedikt, could you take a look? It looks like during VisitPhi, the IfTrue and IfFalse ...
5 years, 1 month ago (2015-11-16 15:47:32 UTC) #2
Benedikt Meurer
Well, I think this is the correct fix, because there's no way to be sure ...
5 years, 1 month ago (2015-11-16 17:40:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450883003/1
5 years, 1 month ago (2015-11-17 09:01:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 09:03:03 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 09:03:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a77f9179e0135afcfe6f62f1451f27517c6b9c61
Cr-Commit-Position: refs/heads/master@{#32025}

Powered by Google App Engine
This is Rietveld 408576698