Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1450823002: SVG should consider base URI when resolving fragment URIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGURIReference.h
diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.h b/third_party/WebKit/Source/core/svg/SVGURIReference.h
index 1caa06ae1496fe8c2b0764e9ff60d4e97c4c5e69..0122dca5256cd08df442c725cf95bc79ef41a402 100644
--- a/third_party/WebKit/Source/core/svg/SVGURIReference.h
+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.h
@@ -42,7 +42,7 @@ public:
static inline bool isExternalURIReference(const String& uri, const Document& document)
{
// Fragment-only URIs are always internal
- if (uri.startsWith('#'))
+ if (document.baseURL() == document.url() && uri.startsWith('#'))
fs 2015/11/17 09:07:54 How is this any different from just removing the s
Shanmuga Pandi 2015/11/17 09:15:35 If a content does not have <base> property , then
return false;
// If the URI matches our documents URL, we're dealing with a local reference.
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698