third_party/WebKit/Source/core/svg/SVGURIReference.h - Issue 1450823002: SVG should consider base URI when resolving fragment URIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1450823002: SVG should consider base URI when resolving fragment URIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('K') | « third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGURIReference.h

diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.h b/third_party/WebKit/Source/core/svg/SVGURIReference.h

index 1caa06ae1496fe8c2b0764e9ff60d4e97c4c5e69..0122dca5256cd08df442c725cf95bc79ef41a402 100644

--- a/third_party/WebKit/Source/core/svg/SVGURIReference.h

+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.h

@@ -42,7 +42,7 @@ public:

static inline bool isExternalURIReference(const String& uri, const Document& document)

{

// Fragment-only URIs are always internal

- if (uri.startsWith('#'))

+ if (document.baseURL() == document.url() && uri.startsWith('#'))

return false;

// If the URI matches our documents URL, we're dealing with a local reference.