Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1450823002: SVG should consider base URI when resolving fragment URIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 23 matching lines...) Expand all
34 public: 34 public:
35 virtual ~SVGURIReference() { } 35 virtual ~SVGURIReference() { }
36 36
37 bool isKnownAttribute(const QualifiedName&); 37 bool isKnownAttribute(const QualifiedName&);
38 38
39 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&); 39 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&);
40 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0); 40 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0);
41 41
42 static inline bool isExternalURIReference(const String& uri, const Document& document) 42 static inline bool isExternalURIReference(const String& uri, const Document& document)
43 { 43 {
44 // Fragment-only URIs are always internal
45 if (uri.startsWith('#'))
46 return false;
47
48 // If the URI matches our documents URL, we're dealing with a local refe rence. 44 // If the URI matches our documents URL, we're dealing with a local refe rence.
49 KURL url = document.completeURL(uri); 45 KURL url = document.completeURL(uri);
50 return !equalIgnoringFragmentIdentifier(url, document.url()); 46 return !equalIgnoringFragmentIdentifier(url, document.url());
51 } 47 }
52 48
53 const String& hrefString() const { return m_href->currentValue()->value(); } 49 const String& hrefString() const { return m_href->currentValue()->value(); }
54 50
55 // JS API 51 // JS API
56 SVGAnimatedString* href() const { return m_href.get(); } 52 SVGAnimatedString* href() const { return m_href.get(); }
57 53
58 DECLARE_VIRTUAL_TRACE(); 54 DECLARE_VIRTUAL_TRACE();
59 55
60 protected: 56 protected:
61 explicit SVGURIReference(SVGElement*); 57 explicit SVGURIReference(SVGElement*);
62 58
63 private: 59 private:
64 RefPtrWillBeMember<SVGAnimatedString> m_href; 60 RefPtrWillBeMember<SVGAnimatedString> m_href;
65 }; 61 };
66 62
67 } // namespace blink 63 } // namespace blink
68 64
69 #endif // SVGURIReference_h 65 #endif // SVGURIReference_h
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/baseuri-href-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698