Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1450803002: Revert of Add unit tests for CdmAdapter (Closed)

Created:
5 years, 1 month ago by zhaoqin
Modified:
5 years ago
Reviewers:
jrummell, xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add unit tests for CdmAdapter (patchset #6 id:100001 of https://codereview.chromium.org/1428753010/ ) Reason for revert: valgrind reports leaks with no-debug-symbol callstack BUG=556346 TBR=jrummell Original issue's description: > Add unit tests for CdmAdapter > > BUG=510088 > TEST=new unittests pass > > Committed: https://crrev.com/30996193fe3e69fe9ccd52471900bf5685c54956 > Cr-Commit-Position: refs/heads/master@{#359582} TBR=xhwang@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -396 lines) Patch
M media/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D media/cdm/cdm_adapter_unittest.cc View 1 chunk +0 lines, -374 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
zhaoqin
Created Revert of Add unit tests for CdmAdapter
5 years, 1 month ago (2015-11-16 03:37:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450803002/1
5 years, 1 month ago (2015-11-16 03:37:56 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-16 03:37:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450803002/1
5 years, 1 month ago (2015-11-16 03:40:40 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-16 03:40:42 UTC) #9
xhwang
On 2015/11/16 03:40:42, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years ago (2015-12-05 06:23:48 UTC) #10
chromium-reviews
5 years ago (2015-12-05 23:25:22 UTC) #11
No, it is not needed any more.
On Dec 5, 2015 1:23 AM, <xhwang@chromium.org> wrote:

> On 2015/11/16 03:40:42, commit-bot: I haz the power wrote:
>
>> No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
>> Even if an L-G-T-M may have been provided, it was from a non-committer,
>> _not_ a full super star committer.
>> See http://www.chromium.org/getting-involved/become-a-committer
>> Note that this has nothing to do with OWNERS files.
>>
>
> Is this CL still needed?
>
> https://chromiumcodereview.appspot.com/1450803002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698