dbus: Add FakeOldBluetooth{Adapter,Device,Manager}

dbus: Add FakeOldBluetooth{Adapter,Device,Manager}

They are used in MockDBusThreadManagerWithoutGMock and stub implementations in DBusThreadManager.

BUG=234084, 234461
TEST=trybots
R=satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197604

[Haruki Sato, 2013-04-26 09:09:05]

JFYI,
Scott, I'd like to add some more fakes for the old
Bluetooth{Adapter,Device,Manager}Client in order to make
MockDBusThreadManagerWithoutGMock ready for browser_tests.
these clients are required from system tray (and maybe some other components?)
so I just would like return a fake.
I think we can just remove them when those old clients are removed.

WDYT?

[keybuk, 2013-04-26 19:25:58]

On 2013/04/26 09:09:05, Haruki Sato wrote:
> JFYI,
> Scott, I'd like to add some more fakes for the old
> Bluetooth{Adapter,Device,Manager}Client in order to make
> MockDBusThreadManagerWithoutGMock ready for browser_tests.
> these clients are required from system tray (and maybe some other components?)
> so I just would like return a fake.
> I think we can just remove them when those old clients are removed.
> 
> WDYT?

You could certainly have MockDBusThreadManagerWithoutGMock do something like
this:

  BluetoothAdapterClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, ...);

to get at the BluetoothAdapterClientStubImpl which is basically a fake

[keybuk, 2013-04-26 19:27:17]

Alternatively use the code from the *StubImpl classes to make the fakes?

[Haruki Sato, 2013-04-30 02:49:00]

On 2013/04/26 19:27:17, keybuk wrote:
> Alternatively use the code from the *StubImpl classes to make the fakes?

Thank you for the comment. We also investigated that approach.
(#msg6 in https://codereview.chromium.org/14392007/)
I think I can factor-out *StubImpl code to these FakeOld*Client.

Satoru, WDYT?

[satorux1, 2013-04-30 04:57:02]

On 2013/04/30 02:49:00, Haruki Sato wrote:
> On 2013/04/26 19:27:17, keybuk wrote:
> > Alternatively use the code from the *StubImpl classes to make the fakes?
> 
> Thank you for the comment. We also investigated that approach.
> (#msg6 in https://codereview.chromium.org/14392007/)
> I think I can factor-out *StubImpl code to these FakeOld*Client.
> 
> Satoru, WDYT?

I think that's what I suggested. Sorry If I wasn't clear. Please replace
*StubImpl classes with the FakeOld*. We don't need both StubImpl and FakeOld

[Haruki Sato, 2013-04-30 08:43:49]

Moved the code for StubImpl* to Fake*. PTAL.
Thanks.

[satorux1, 2013-05-01 04:35:24]

LGTM with a suggestion:

https://codereview.chromium.org/14508007/diff/13001/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

https://codereview.chromium.org/14508007/diff/13001/chromeos/chromeos.gyp#new...
chromeos/chromeos.gyp:415: 'dbus/fake_old_bluetooth_manager_client.h',
the fake_old_* stuff may be unnecessary here, as it's listed in the 'dbus'
target

[Haruki Sato, 2013-05-01 05:44:31]

https://codereview.chromium.org/14508007/diff/13001/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

https://codereview.chromium.org/14508007/diff/13001/chromeos/chromeos.gyp#new...
chromeos/chromeos.gyp:415: 'dbus/fake_old_bluetooth_manager_client.h',
On 2013/05/01 04:35:24, satorux1 wrote:
> the fake_old_* stuff may be unnecessary here, as it's listed in the 'dbus'
> target
They are necessary as these Fake*Client are now working as stubs (for 'chromeos'
target)and test utils (for 'chromeos_test_support_without_gmock' target).

[commit-bot: I haz the power, 2013-05-01 05:44:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/14508007/13001

[commit-bot: I haz the power, 2013-05-01 07:50:42]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-01 07:52:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/14508007/13001

[commit-bot: I haz the power, 2013-05-01 10:42:34]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[Haruki Sato, 2013-05-01 13:01:24]

Committed patchset #3 manually as r197604 (presubmit successful).